Add content_type for Response
#3551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hey, @tomchristie , what do you think of this suggestion? |
Kludex
reviewed
May 30, 2025
| Return the Content-Type header. | ||
| """ | ||
| result = self.headers.get("Content-Type") | ||
| return str(result) if result else None |
Contributor
There was a problem hiding this comment.
Why the str() cast? Isn't it str already?
Author
There was a problem hiding this comment.
It's not str, it's Any
class Headers(typing.MutableMapping[str, str]):
def get(self, key: str, default: typing.Any = None) -> typing.Any:
...
There was a problem hiding this comment.
Actually, result defaults to None if the key is not present in the HTTP headers due to how the Headers.get function works, so you may as well return self.headers.get("Content-Type").
Contributor
|
I think this is not needed, but we can see what other maintainers think about it. |
Contributor
Indeed. Appreciate the interest tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I would like to suggest adding a little syntax sugar. It might be more convenient to use
response.content_typeinstead ofresponse.headers.get("Content-Type").I hope I haven't forgotten any places where changes need to be made
Checklist